Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transaction_outputs #20456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update transaction_outputs #20456

wants to merge 1 commit into from

Conversation

xiaodi007
Copy link
Contributor

Description

  1. possible_to_receive.iter().clone() -> possible_to_receive.into_iter():

This modification is generally appropriate and improves performance by avoiding unnecessary cloning of the possible_to_receive collection. Instead of cloning, it consumes the iterator, which is more efficient.

  1. .chain(received_objects) -> .chain(received_objects.into_iter()):

By calling into_iter() on received_objects when adding them to locks_to_delete, the objects are directly used in the collection and the original reference to received_objects is no longer necessary.

  1. ** Correct the spelling error in transaction_orchestrator**:

fnished -> finished

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:52am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:52am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:52am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant